[MPlayer-dev-eng] [PATCH] set is_streamed correctly in lavf URLContext

[Reimar Döffinger]

Hello,
On Wed, Dec 19, 2007 at 02:05:07PM +0100, Michael Niedermayer wrote:
[...]
> > > If sizeof(ByteIOContext) can change between lavf minor version, then
> > > it shouldn't be part of public API.
> > > Maybe the definition of ByteIOContext should be moved to a private
> > > header and only the declaration should be kept in public header ?
> > 
> > Maybe ...
> 
> After thinking about this again and after reimars comments, i think yes we
> should remove it, we can always add it back with a
> 
> #ifndef INTERNAL
> uint8_t array[INT_MAX];
> #endif
> in it to make misuse harder

Given the reason for all this and that there seems no other way to set
is_streamed that seems a bit stupid...

> Mplayers lavc/lavf wrapers certainly serve as examples for other projects.
> And if they are filled with ugly hacks which break lavcs ABI/API then this
> will negatively affect more than just mplayer.

Well, I am trying to fix it (at least from time to time), but the reason
for most of those ugly hacks is that there is no proper way to do it.
Once there is a proper way and we switched to it I will consider writing
the code in such a way that it works across revisions, but I don't see a
point in bothering with such details while there are glaring problems.

Greetings,
Reimar Döffinger