[MPlayer-dev-eng] [PATCH] set is_streamed correctly in lavf URLContext

[Michael Niedermayer]

On Wed, Dec 19, 2007 at 08:28:49AM +0100, Reimar Döffinger wrote:
> Hello,
> On Tue, Dec 18, 2007 at 09:32:43PM -0500, Rich Felker wrote:
> > On Wed, Dec 19, 2007 at 03:07:44AM +0100, Michael Niedermayer wrote:
> > > On Tue, Dec 18, 2007 at 10:22:43PM +0100, Reimar Döffinger wrote:
> > > > On Tue, Dec 18, 2007 at 08:24:41PM +0100, Michael Niedermayer wrote:
> > > > > On Sat, Dec 15, 2007 at 05:35:19PM +0100, Reimar Döffinger wrote:
> > > > [...]
> > > > > >  typedef struct lavf_priv_t{
> > > > > >      AVInputFormat *avif;
> > > > > >      AVFormatContext *avfc;
> > > > > > -    ByteIOContext *pb;
> > > > > > +    ByteIOContext pb;
> > > > > > +    uint8_t buffer[BIO_BUFFER_SIZE];
> > > > > 
> > > > > you assume that sizeof(ByteIOContext) will not change between lavf versions,
> > > > > or you just dont care that it will break even with minor version bumps ... :)
> > > > 
> > > > Actually the later one...
> > > 
> > > dont you care a little bit about compatibility? with such design you could
> > > drop shared lib libav* support from mplayer
> > 
> > I would be very much in favor of dropping shared support.
> 
> This has nothing to do with shared or not, we have always made very
> clear that we only support versions of FFmpeg from exactly the same time
> as MPlayer, even though that has some problems for regression testing.

we= new team ;)
always= recently

"long" time ago there where tons of #ifdefs in libmpcodecs/*lavc* to make
mplayer work with all past versions of libav*

Anyway i dont care much. But i suggest that you add a check to configure
to check for this requirement of same version and warn the user if its
not fullfilled.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- Måns Rullgård
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071219/9f447ce6/attachment.pgp>