[MPlayer-dev-eng] [PATCH] remove internal unrarlib

[Ulion]

2007/12/18, Diego Biurrun <diego at biurrun.de>:
> On Tue, Dec 18, 2007 at 09:03:24AM +0800, Ulion wrote:
> > 2007/12/18, Diego Biurrun <diego at biurrun.de>:
> > > Now that unrarexec is in place, unrarlib is obsolete.  Here is a patch
> > > to remove it (minus the deleted unrarlib.[ch]).  Should be trivial, but
> > > I'd like to hear some approval about the changes to unrarexec.h.  I
> > > copied over the struct definitions from unrarlib.h replacing the types
> > > by their proper (Unix?) equivalents.  Hopefully this is the best way to
> > > do this.
> > >
> > > Shall be applied on Thursday if no objections/problems arise.
> >
> > Here's output columns of 'unrar v' command:
> >
> > Pathname/Comment
> >                   Size   Packed Ratio  Date   Time     Attr      CRC   Meth Ver
> >  xxxxxxx.xxx
> >                 216596   193359  89% 14-09-07 08:48  .....A.   60AF02D3 m3d 2.9
> >
> >
> > If any member in the struct not list here, could be removed since we
> > will never get it.
>
> Do I understand correctly that you are referring to the struct
>
> struct RAR20_archive_entry
> {
>   char           *Name;
>   unsigned short NameSize;
>   unsigned long  PackSize;
>   unsigned long  UnpSize;
>   unsigned char  HostOS;
>   unsigned long  FileCRC;
>   unsigned long  FileTime;
>   unsigned char  UnpVer;
>   unsigned char  Method;
>   unsigned long  FileAttr;
> };
>
> and that you are trying to say that the members HostOS and NameSize
> could be removed?

ya, also we can remove '20' from the struct name since we do not only
work with rar 2.*.


-- 
Ulion