[MPlayer-dev-eng] [PATCH] Build CTAGS/ETAGS

[Benjamin Zores]

Diego Biurrun a écrit :
> On Sun, Dec 16, 2007 at 01:33:44PM +0100, Benjamin Zores wrote:
>> Attached patch adds two new rules to Makefile:
>> - make TAGS
>> - make tags
> 
> Why two names?
> 
>> --- Makefile	(revision 25414)
>> +++ Makefile	(working copy)
>> @@ -314,6 +314,22 @@
>>  strip:
>>  	strip -s $(ALL_PRG)
>>  
>> +define all-sources
>> +        (  find -name '*.[chS]' -print  )
>> +endef
> 
> This is only used once, why this unnecessary complication?
> 
>> +TAGS:
>> +	@rm -f TAGS; \
>> +	$(call xtags,etags)
>> +
>> +tags:
>> +	@rm -f tags; \
>> +	$(call xtags,ctags)
> 
> Could be folded into one rule.
> 
> Overall the patch looks like a three liner that has been blown up to
> quadruple size.  I don't see why this should need more than one simple
> rule.

Still 2 rules as there are 2 tag formats but a bit smaller.
You prefer this way ?


Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-mplayer-tags.diff
Type: text/x-diff
Size: 1021 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071216/037bd184/attachment.diff>