[MPlayer-dev-eng] [PATCH] Build CTAGS/ETAGS

[Diego Biurrun]

On Sun, Dec 16, 2007 at 01:33:44PM +0100, Benjamin Zores wrote:
>
> Attached patch adds two new rules to Makefile:
> - make TAGS
> - make tags

Why two names?

> --- Makefile	(revision 25414)
> +++ Makefile	(working copy)
> @@ -314,6 +314,22 @@
>  strip:
>  	strip -s $(ALL_PRG)
>  
> +define all-sources
> +        (  find -name '*.[chS]' -print  )
> +endef

This is only used once, why this unnecessary complication?

> +TAGS:
> +	@rm -f TAGS; \
> +	$(call xtags,etags)
> +
> +tags:
> +	@rm -f tags; \
> +	$(call xtags,ctags)

Could be folded into one rule.

Overall the patch looks like a three liner that has been blown up to
quadruple size.  I don't see why this should need more than one simple
rule.

Diego