[MPlayer-dev-eng] [PATCH] Fix memleak in stream_dvb.c (and libmenu patch)

Nico Sabbi Nicola.Sabbi at poste.it
Sun Dec 16 09:59:06 CET 2007


Il Sunday 16 December 2007 00:25:18 Andrew Calkin ha scritto:
> 2007/12/16, Reimar Döffinger 
<Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> > On Sun, Dec 16, 2007 at 07:31:06AM +0900, Andrew Calkin wrote:
> > [...]
> >
> > > I suspected there would be bugs in my code- i wrote it on a
> > > friday afternoon at work in about 10mins, just before running
> > > off to a sports game. I did not have time to test, and only
> > > checked that it compiled first. But, since only patches
> > > submitted seem to get a response, and i knew it would get a
> > > proper review, it would be faster than me digging out my dvb
> > > h/w which i have no time to use nowadays anyway.
> >
> > [...]
> >
> > You can simply add a small comment like "note: I did not (yet)
> > properly test it" or something like that, that's what I usually
> > do. It's not important but it IMO reduces the risk of annoying a
> > reviewer in case he has a bad day :-)
>
> OK, thanks for the advice. I'll do that from now on, if I can't
> test it.
>

actually your previous post sounded like a reply to a message
I never posted ...



More information about the MPlayer-dev-eng mailing list