[MPlayer-dev-eng] [PATCH] Fix memleak in stream_dvb.c (and libmenu patch)

Nico Sabbi Nicola.Sabbi at poste.it
Sat Dec 15 14:43:24 CET 2007


Il Saturday 15 December 2007 13:15:46 Andrew Calkin ha scritto:
> 2007/12/15, Andrew Calkin <calkina at geexbox.org>:
> > 2007/12/15, Nico Sabbi <Nicola.Sabbi at poste.it>:
>
> Hi Nico,
>
> Don't bother replying, Ulion provided a good explanation of the
> error I made.
>
> I look forward to your patch.
>
> //Andrew

applied dvb_free_config() after having reformatted it
and removed some useless check. You also forgot
to call it from withing libmenu/menu_dvbin.c.

Of course every new open of stream_dvb.c will have
to re-parse the config files, but not when switching
channels, for example:

$ mplayer dvb://LA72   file.avi   dvb://MTV 
will parse the files twice, but it's much cleaner
(and not so commonly used to worry for the slowdown)


Thanks,
	Nico



More information about the MPlayer-dev-eng mailing list