[MPlayer-dev-eng] [PATCH] Fix memleak in stream_dvb.c (and libmenu patch)

Nico Sabbi Nicola.Sabbi at poste.it
Sat Dec 15 13:04:07 CET 2007


Il Saturday 15 December 2007 11:24:39 Nico Sabbi ha scritto:

> this is wrong for 2 reasons:
> -you are duplicating in new_config some memory malloc()ated in
> dvb_get_config() including the old pointers
> - the .name should be strdup()ed
>
> Also, better call dvb_get_config() a second time in menu_dvbin.c
> and removing the file-static variable in stream_dvb.c rather than
> adding so much game with memory in stream_dvb.c

BTW, don't bother sending another patch: I'm already fixing this
issue and cleaning the code overall



More information about the MPlayer-dev-eng mailing list