[MPlayer-dev-eng] [PATCH] stream_cdda seek to end fix

[Reimar Döffinger]

Hello,
On Fri, Dec 14, 2007 at 05:55:22PM +0800, Ulion wrote:
> 2007/12/14, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > On Thu, Dec 13, 2007 at 02:35:22PM +0800, Ulion wrote:
> > [...]
> > > the fill_buffer() function does not ready for reading out size the
> > > sector range, that's what my patch check range in seek(). So it's
> > > totally ok to set eof in seek when sector out of range in current
> > > code.
> >
> > I did not mean to imply that your patch is wrong, it definitely is
> > right.
> > But the bug was MPlayer hanging, and this patch does not fix the bug
> > that causes the hang, it only hides it.
> > A bit like that old joke:
> > Patient: If it press here it hurts!
> > Doctor: Then don't press there.
> 
> Oh, the hang is out of our control, isn't it?

It seems so, yes (though things might be different when using libcdio instead of libcdda).
I just said this to make sure my comment was understood
the way I meant it.

Greetings,
Reimar Döffinger