[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

[Diego Biurrun]

On Wed, Dec 12, 2007 at 11:14:50PM +0800, Ulion wrote:
> 2007/12/12, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > > If there's no objection, I will apply this patch in 2 days.
> >
> > I _strongly_ object to having the MinGW version enabled by default,
> > since even Microsoft obviously does not know how to do escaping
> > correctly I do not have any confidence whatsoever that this code is
> > correct.
> > Actually am somewhat opposed to having this functionality for MinGW
> > at all unless we find a way to _guarantee_ the escaping does not
> > introduce exploitable bugs.
> 
> I insist commit the mingw version and set it default disabled on mingw
> when compiling.

This is not going to get us anywhere.  The patch is big enough as it is.
Please commit it without the MinGW parts, we can see about the rest
later.

Diego