[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Dec 13 10:39:45 CET 2007


Hello,
On Thu, Dec 13, 2007 at 12:40:44AM -0500, Rich Felker wrote:
> On Wed, Dec 12, 2007 at 12:32:14PM -0600, Stuart Levy wrote:
> > Also, would cmd_escape_append() be more palatable if it
> > simply rejected all but a limited set of safe characters, like
> > letters, digits, blanks, -+=&,.:_/\[](){}?
> 
> No, this would simply be buggy since real filenames can and will
> contain arbitrary characters.

The idea is that buggy is better than exploitable, since it seems
unclear if non-exploitable is possible without getting the Windows
source code (and of all versions we support in addition), since even
the official documentation seems contradictory.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list