[MPlayer-dev-eng] [PATCH] Fix bug libass always use fontconfig does not care -nofontconfig

[Rich Felker]

On Wed, Dec 12, 2007 at 06:57:48AM -0500, The Wanderer wrote:
> Diego Biurrun wrote:
> 
> > On Wed, Dec 12, 2007 at 08:57:49AM +0800, Ulion wrote:
> > 
> >> Here's updated patch with man page update.
> >> 
> >> --- DOCS/man/en/mplayer.1	(revision 25370)
> >> +++ DOCS/man/en/mplayer.1	(working copy)
> >> @@ -1982,6 +1982,11 @@
> >>  With this option, libass will be used for SSA/ASS
> >>  external subtitles and Matroska tracks.
> >>  You may also want to use \-embeddedfonts.
> >> +.br
> >> +.I NOTE:
> >> +When fontconfig is compiled in, if \-ass turns on,
> >> +\-fontconfig will be auto-enabled unless explicitly
> >> +turn off \-fontconfig in config file or command line.
> > 
> > When fontconfig is compiled-in, \-ass turns on \-fontconfig unless
> > explicitly turned off with \-nofontconfig.
> 
> FWIW, I disagree with the addition of the hyphen in "compiled-in" - it
> reads worse to me that way than without it. I would hyphenate that
> phrase as an adjective in certain contexts ("a compiled-in version of
> fontconfig"), for unambiguous grouping, but it does not read well to me
> here.

It's also incorrect English usage. Hyphenation is correct only when
the entire phrase is used as a modifying adjective/participial phrase,
to eliminate ambiguity. Here "is compiled in" is simply the predicate,
with the somewhat objectionable but widely used preposition "in"
lacking an explicit object.

Rich