[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

[Stuart Levy]

On Wed, Dec 12, 2007 at 11:14:50PM +0800, Ulion wrote:
  [...]
> +    int mlen = (strlen(executable)+strlen(archive)+filename?strlen(filename):0)*3+100;

This needs parentheses, doesn't it?  As in:
    int mlen = (strlen(executable)+strlen(archive)+(filename?strlen(filename):0))*3+100;
As written it'd yield 3*strlen(filename)+100, or crash if filename was NULL.

Also, would cmd_escape_append() be more palatable if it
simply rejected all but a limited set of safe characters, like
letters, digits, blanks, -+=&,.:_/\[](){}?