[MPlayer-dev-eng] [PATCH] stream_cdda seek to end fix

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Wed Dec 12 14:32:47 CET 2007


Hello,
On Wed, Dec 12, 2007 at 09:17:05PM +0800, Ulion wrote:
> It seems rare people use mplayer to play cd, stream_cdda can not even
> seek to end, it hangs with 'Track 1' printed in verbose output,
> indeed, that's the default value of variable seeked_track, but sector
> is already out of tha end_sector. Here's a patch for it.

Shouldn't it better instead handle the seek error properly? If it hangs
like this I'd assume it will hang the same way e.g. with a scratched
CD..
And even if this is the best solution, preferably any code that can
cause hangs should be eliminated (I have a similar problem with the TV
code, if the reception is bad MPlayer can hang for several minutes
before reacting to input, though some of it might be because (AFAICT)
simply all TV-related kernel-drivers are full of bugs).

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list