[MPlayer-dev-eng] [PATCH] Fix bug libass always use fontconfig does not care -nofontconfig

[Evgeniy Stepanov]

On Wednesday 12 December 2007 03:57:49 Ulion wrote:
> 2007/12/12, Evgeniy Stepanov <eugeni.stepanov at gmail.com>:
> > On Tuesday 11 December 2007 12:49:41 Ulion wrote:
> > > 2007/12/11, Jan Knutar <jknutar at nic.fi>:
> > > > On Monday 10 December 2007 06:07, Ulion wrote:
> > > > > The first attachment is a simple the fix for use font_fontconfig at
> > > > > runtime. fontconfig will always be runtime disabled if user not
> > > > > enable it by command line or config file (mplayer default setting).
> > > >
> > > > IMO it's bad to change the established behaviour
> > >
> > > Do you mean you perfer the second patch?
> >
> > I also prefer the second patch. Changing the default behaviour means that
> > for a lot of users things will stop working all of a sudden.
> >
> > Notice that the way you do it, fontconfig will still be initialized. This
> > means reading and possibly rebuilding font cache, feeding memory fonts to
> > freetype. It's better to avoid all this by calling non-fontconfig
> > versions of _init and _select if (font_fontconfig<0).
>
> Sure, I found fontconfig_init and fixed it also, fontconfig_select was
> already fixed in the patch, and _select_font only be called by
> fontconfig_select, so I think it's ok now. Here's updated patch with
> man page update.

Seems ok.