[MPlayer-dev-eng] [PATCH] color SPU with ass (EOSD)

[Evgeniy Stepanov]

On Tuesday 04 December 2007 16:40:40 Ötvös Attila wrote:
> Ezzel a dátummal: Tuesday 04 December 2007 14.25.09 Ulion ezt írta:
> > That's all I can do. You may contact Evgeniy Stepanov to see whether
> > he can help you to commit these patches.

I'm not sure what to do with these patches. The generators part has some minor 
problems. For instance, vo_gl does not work correctly when there is more than 
non-empty image list for the same frame. It won't segfault either, but only 
one of the lists will be displayed. On the other hand, this never happens 
with the current code, because, obviously, any subtitle track is either 
SSA/ASS, or VobSub, not both. It will happen if, for example, OSD is rendered 
with libass at some point in future.

On the positive side, the code seems to work fine and not break anything, and 
it could be improved in the future with small, incremental changes. And the 
feature is really useful. With the current black-and-white display some 
(rare) VobSubs are completely unreadable, and others are not very pretty, 
compared to other video players.

I will not be working on this code or MPlayer in general till February at 
least. That includes fixing bugs, except for the most trivial. But I don't 
want to hold this patch either. So, if the above arguments are ok, then let's 
commit it and see what comes next. If not - someone should rewrite the 
questionable parts or even go for the non-ass version.