[MPlayer-dev-eng] Chapter selection via libmenu

[Nico Sabbi]

Il Monday 10 December 2007 11:03:50 Nico Sabbi ha scritto:
> Il Monday 10 December 2007 10:56:35 Benjamin Zores ha scritto:
> > On Dec 10, 2007 10:54 AM, Nico Sabbi <Nicola.Sabbi at poste.it> 
wrote:
> > > unacceptable, rejected
> >
> > reason being ?
> > that would help at lot fixing the patch i guess.
>
> dereferencing stream_priv and making the code stream-specific
> is the recipe for very bad coding and for hitting on problems
> in the future.
> Chapters are handled at the demuxer layer (with the aid of the
> stream layer) so use the DEMUXER_CTRL functions available or add
> some if the existing ones are not sufficient

as a general rule:
- modular coding
- *never* resort to shortcuts
- don't touch structures that don't belong to you