[MPlayer-dev-eng] [PATCH] vobsub custom colors rgb->yuv fix.

Ulion ulion2002 at gmail.com
Sat Dec 8 11:29:23 CET 2007


2007/12/8, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> Hello,
> On Sat, Dec 08, 2007 at 10:41:09AM +0800, Ulion wrote:
> [...]
> > y space fix done.
> > Tomorrow I will apply the custom color rgb->yuv fix. Is it ok to use
> > lavcodec/colorspace.h, Reimar? It's just a file with macroes, and will
> > always be there within mplayer directory, isn't it?
>
> We shouldn't depend on it regardless.
> IMO add a
> uint32_t vobsub_rgb_to_yuv(uint32_t)
> function to vobsub.c that does this conversion and reuse it.

A function is good, but now the one used to custom colors are in
vobsub.c and libmpdemux/demux_mkv.c, does that mean let demux_mkv.c
include vobsub.h?

-- 
Ulion



More information about the MPlayer-dev-eng mailing list