[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

Rich Felker dalias at aerifal.cx
Fri Dec 7 04:46:42 CET 2007


On Thu, Dec 06, 2007 at 11:08:02PM +0100, Reimar Doeffinger wrote:
> Hello,
> On Thu, Dec 06, 2007 at 01:50:25PM -0500, Rich Felker wrote:
> [...]
> > Yes, he wanted to avoid the fork though in case it's not needed. Not a
> > big deal, but each MPlayer senselessly and unconditionally performing
> > an unnecessary fork for each file is rather annoying.
> 
> Unless I misunderstood the code that is _only_ in case someone explicitly set
> the unrar binary to something that does not exist or at least can't be
> executed. I do wonder if that is worth even the one additional line of code....

Oh, I thought the case where it was blank was subsumed into that.. If
it's only for when the name is set incorrectly then I agree it's a
wasteful test.

Rich



More information about the MPlayer-dev-eng mailing list