[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

[Rich Felker]

On Thu, Dec 06, 2007 at 07:28:40PM +0100, Reimar Doeffinger wrote:
> Hello,
> On Thu, Dec 06, 2007 at 08:00:00AM -0500, Rich Felker wrote:
> > On Thu, Dec 06, 2007 at 08:46:48PM +0800, Ulion wrote:
> > > 2007/12/6, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > > > On Thu, Dec 06, 2007 at 07:20:54PM +0800, Ulion wrote:
> > > > > With Rich's suggestion, patch updated:
> > > > > 1. Remove access check code change to use access() call.
> > > >
> > > > What is the point of that though? And why not put it in the pipe_open
> > > > function, together with the unrar_executable != NULL check?
> > > 
> > > I meant use access() instead of stat(). As move them into pipe_open,
> > > I'd like to, but current pipe_open are splited by MINGW macro and some
> > > declaration at beginning of each part of #ifdef. Then that need two
> > > copy of access check code also, so that looks not better than current
> > > implement.
> > 
> > I don't care where access(2) is called as long as it's used instead of
> > the (incorrect; ignoring permissions) use of stat(2).
> 
> Well, I actually wanted to know what the point is at all, shouldn't the execl
> fail anyway? It seems redundant to me to use anything at all, esp. since no
> useful error message is printed.

Yes, he wanted to avoid the fork though in case it's not needed. Not a
big deal, but each MPlayer senselessly and unconditionally performing
an unnecessary fork for each file is rather annoying.

Rich