[MPlayer-dev-eng] [PATCH] Use unrar for open vobsubs if available

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Thu Dec 6 14:05:34 CET 2007


Hello,
On Thu, Dec 06, 2007 at 08:00:00AM -0500, Rich Felker wrote:
> > I just checked the API you mentioned, it seems be used parsing whole
> > command line into argv list, it's not what we needed, if there's such
> > api match our needs, we should use it. By now, we still can only use
> > our escape function for that.
> 
> Reimar meant using it after the conversion to convert back and make
> sure the composition of the two maps is the identity. This _should_ be
> a redundant check, but it was intended to prevent any security bugs
> from slipping through. I still think it would be nicest if you could
> remove the use of cmd.exe entirely.

I agree, though with windows the advantage isn't quite as big since
Windows seems to _only_ support a command line, starting a program with
argc/v is not supported at all it seems.
I guess that's a leftover from the DOS days...

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list