[MPlayer-dev-eng] [PATCH] color SPU with ass (EOSD)

[Ötvös Attila]

Ezzel a dátummal: Tuesday 04 December 2007 13.25.41 Ulion ezt írta:

Hi Ulion!


> 2007/12/4, Ötvös Attila <oattila at chello.hu>:
> > Ezzel a dátummal: Tuesday 04 December 2007 05.12.23 Ulion ezt írta:
> > Hi Ulion!
> >
> > > 2007/12/4, Ötvös Attila <oattila at chello.hu>:
> > > > 2007. december 3. 13.32 dátummal Ulion ezt írta:
> > > > Hi Ulion!
> > > >
> > > > > I tested with your patch.
> > > > >
> > > > > spudec.c:1334: warning: unused variable 'i'
> > > >
> > > > I fixed.
> > > >
> > > > > In second patch, when first happens:
> > > > > +    h = FFMIN(bitmap_h,dmpi->h - dst_y);
> > > > > +    w = FFMIN(bitmap_w,dmpi->w - dst_x);
> > > > > Beginning should be tabs instead of spaces.
> > > >
> > > > I corrected.
> > > >
> > > > > Functions you added parameters dxs, dys, you should document them
> > > > > if original functions have comments.
> > > >
> > > > I added.
> > > >
> > > > > And at such like this line-break places:
> > > > > +static void ass_eosd_generator(double pts, unsigned int dxs,
> > > > > unsigned int dys, +       mp_eosd_images_t* dst, void* data)
> > > >
> > > > I corrected.
> > >
> > > There are other places like this or tab/space not match context, I
> > > will metion the line number in your patch file:
> > > Second patch:
> > > line 47, line 94, line 168, line 244, line 272 (also comments for
> > > dxs/dys), line 292
> > > Third patch:
> > > line 260 (if you'd like to align the parameters), line 278, line 287,
> > > line 326 (if you'd like to)
> > > , line 374 and following part codes need fix indent. line 666, u and v
> > > are reverted.
> >
> > I corrected.
>
> I found your first attachment is an all-in-one patch, then I just talk

I sorry. My mistake. Now I splited.

> about it: line 235: remove tailing space
> line 247: for best alignment for users with different tab length:
>
> -                       my_draw_bitmap(vf, img->bitmap, img->w,
> img->h, img->stride,
> -                                       img->dst_x, img->dst_y,
> img->color); +                       switch (img->format) {
> +                       case ASS_FMT_RGBA8:
> +                               my_draw_rgba8(vf, img->bitmap, img->w,
> img->h, img->stride,
> +                                              img->dst_x, img->dst_y,
> img->color);
>
> Here the last line should use space corresponding to the
> 'my_draw_rgba8(' part of the preivous line.
>
> line 265: should use spaces
> line 474, line 487, line 534: alignment
> line 1121: all spaces should be good

I corrected.

Best regard.
Attila
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ass-fmt_and_gen-eosd.patch
Type: text/x-diff
Size: 9531 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071204/6bf9f186/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ass-unregister_and_scaler.patch
Type: text/x-diff
Size: 9355 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071204/6bf9f186/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: color-spu-with-ass.patch
Type: text/x-diff
Size: 26789 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071204/6bf9f186/attachment-0002.patch>