[MPlayer-dev-eng] [PATCH] Adjust log level from error to warning when auto loading sub fails.

[Ulion]

2007/12/3, Ulion <ulion2002 at gmail.com>:
> 2007/12/3, Ulion <ulion2002 at gmail.com>:
> > 2007/12/3, Diego Biurrun <diego at biurrun.de>:
> > > On Sun, Dec 02, 2007 at 06:10:44PM +0200, Uoti Urpala wrote:
> > > > On Sun, 2007-12-02 at 07:35 +0800, Ulion wrote:
> > > > > 2007/12/2, Uoti Urpala <uoti.urpala at pp1.inet.fi>:
> > > > > > On Fri, 2007-11-30 at 13:01 +0800, Ulion wrote:
> > > > > > > +    if (!asst && !subd && silent < 2)
> > > > > >
> > > > > > Does anything use silent >= 2?
> > > > >
> > > > > No, but the parameter named 'silent', it should support 'really
> > > > > silent' like it was if needed.
> > > > > So I keep the feature, does this make sense?
> > > >
> > > > I think it's usually a bad idea to add extra generality/features which
> > > > are currently unused "in case they'll be needed", unless you have a
> > > > clear plan that involves using them soon.
> > >
> > > Seconded.  This is the perfect recipe for adding unused cruft to the
> > > codebase.  And yes, it has happened countless times in the past.
> >
> > OK, then my last patch change silent to noerr should be ok? If there's
> > no object, I will apply that tomorrow.
>
> Indeed the function declared in mp_core.h, I just a little worried
> about there was some other codes outside mplayer could use this
> function.

Done.

-- 
Ulion