[MPlayer-dev-eng] [PATCH] Remove osd menu hardcoded keybindings, support custom keybindings.

[Andrew Calkin]

2007/12/4, Ulion <ulion2002 at gmail.com>:
> 2007/12/4, Alban Bedel <albeu at free.fr>:
> > On Mon, 3 Dec 2007 00:26:03 +0800
> > Ulion <ulion2002 at gmail.com> wrote:
> >
> > > > I have been thinking about this a bit more. It can be made in a
> > > > simpler way. On a keypress, when there is a bind it should just be
> > > > queued as a normal mplayer command. If no bind is found the
> > > > keypress is passed to the menu.
> > >
> > > It could, although it's an indirect way to send menu cmd, but it looks
> > > more extendable, new patch queue cmd is here.
> >
> > Yes, it add one inderection for the menu commands, but it's much more
> > usefull if ppl can also define global key for the volume and such.
> >
> > > >
> > > > +<keybindings name="cmdlist" parent="list" />
> > > >
> > > > Hmm, 'name' is not good here, it should be 'menu-type' or something
> > > > like this, that's what it is.
> > >
> > > It not only match menu's type, indeed it first try to match menu's
> > > name, so each menu can have different key bindings even with same menu
> > > type. If menu name match fails, then try to match menu type name, if
> > > still fails, fallback to use default key bindings.
> > > So 'name' is the only word by now I can thought to use, and we can
> > > consider it as the keybindings' name. Or some other words you can
> > > suggest except 'menu-type'?
> >
> > Not really, that will do. Otherwise afaict the patch is ok.
> >
>
> I'm sorry, Albeu, I didn't get your meaning of the 'that will do', do
> you mean 'name' is acceptable. I'm little confused by the following
> 'Otherwise' word.

In English "that will do" means the same as "that will suffice" or
"that is enough" (depending on the context), so he's saying the patch
is fine.

I am also waiting for this patch to be applied, hence my reply :-)

//Andrew