[MPlayer-dev-eng] [PATCH] fix printf format string warnings

[Diego Biurrun]

On Thu, Nov 29, 2007 at 10:11:29PM -0500, Rich Felker wrote:
> On Thu, Nov 29, 2007 at 03:42:55PM +0100, Diego Biurrun wrote:
> > > Othogonal? Well, if it was "fixed" that patch would have to be reverted
> > > again (well, maybe using PRId32 etc. would be nicer, but not really
> > > necessary).
> > > Changing it in the header would probably very, very slightly simplify
> > > adding support for 64 bit DLLs (not that I'm sure we'll ever add that).
> > 
> > That's basically what I mean by orthogonal.  If somebody should extend
> > this to 64 bits, more extensive changes will be required anyway.  I
> > don't see how my patch is making this any harder...
> 
> That's IMO a misuse of the word orthogonal. Orthogonal changes should
> be thought of as something almost like diff files that commute, i.e.
> applying them in the opposite order gives the same results. For
> practical purposes it might be desirable to relax this requirement
> somewhat, but conceptually it should still mean something similar.

You're probably right that I'm abusing terminology somewhat.  In any
case Reimar had no further objections to the patch on IRC, so I
committed.

Diego