[MPlayer-dev-eng] Color SPU/OSD

[Ötvös Attila]

2007. december 2. 14.21 dátummal Ulion ezt írta:
Hi Ulion!

Thank your answer.

> 2007/11/28, Ötvös Attila <oattila at chello.hu>:
> > Hi All!
> >
> > Is it good now to return?
> >
> > Color SPU/OSD with draw_alpha:
> >
> > 2007-08-11: [PATCH] color SPU - part 1
> > http://archives.free.net.ph/message/20070811.172218.164ea735.en.html
> >
> > and/or
> >
> > Color SPU/OSD with ass (eosd):
> >
> > 2007-08-15: [PATCH] color SPU with ass (EOSD)
> > http://archives.free.net.ph/message/20070815.180032.5425c7b8.en.html
>
> I'd like to see spu support color also. But patches should one by one,
> put them all together make it harder to be reviewed and commited.
>
> The most earlier patch was writen by Evgeniy Stepanov, he can take
> good care of ass part code, also can commit. You should discuss with
> him to push the patch tobe applied.
>
> Here's my personal review:
>
> Your unregister patch seems try to improve his version, but has little
> problem: dxs, dyx in the parameter list of ass_eosd_generator seems not get
> used in 2 of 3 ass_eosd_generator functions, does these two parameters has
> to be added?

I think it is needed.
The internal (libass) eosd_generator uses the ass_configure().
The external (libass) eosd_generator uses the dxs,dys parameter of 
eosd_generator().

> As the color-spu part:
> eosd_register_number + 1 is ugly, just check it  >= 0 and default -1
> to avoid this.

It is corrected in original mail thread:
http://archives.free.net.ph/message/20070815.180032.5425c7b8.en.html

Best regard.
Attila