[MPlayer-dev-eng] [PATCH] Remove osd menu hardcoded keybindings, support custom keybindings.

[Alban Bedel]

On Sat, 1 Dec 2007 14:18:11 +0800
Ulion <ulion2002 at gmail.com> wrote:

> Hello,
> 
> There are keybindings in libmenu for browse osd menu, but it's
> hardcoded, can not be customized.
> This patch remove the hardcoded keybindings, and support user defined
> keybindings from osd menu  browsering.
> As we known, each input key has only one possible binding defined
> input.conf, such as arrow up, down, left, and right, but when browsing
> osd menu, you probably want to use these keys, then they are hardcoded
> in libmenu. But for users want to use other key to browse osd menu,
> there's no way to custom browsing keybindings, so I made this patch
> fix the problem.

Good idea, the patch seems fine. But why do you change the read_key()
return type from void to int? afaict from the patch it's useless, but
as it's mixed changes that's hard to say. If you *realy* need to change
the prototype then do it in another patch.

	Albeu