[MPlayer-dev-eng] [PATCH] stream layer support for .ifo files

[Vladimir Voroshilov]

2007/12/1, Nico Sabbi <Nicola.Sabbi at poste.it>:
> Il Friday 30 November 2007 23:42:59 Nico Sabbi ha scritto:
>
> > > Is it okay to apply or sth inflammable ?
> > >
> > > If okay, I might add some later option for prefered ifo file
> > > playback (i.e. dvd:// or dvdnav://)
> > >
> > > Ben
> >
> > if you really insist on committing this code you can at
> > least minimize the nonsense and add the stream definition
> > and the function in stream_dvd.c
> > _______________________________________________
>
>
> Index: stream/stream.c
> ===================================================================
> --- stream/stream.c     (revision 25214)
> +++ stream/stream.c     (working copy)
> @@ -85,6 +85,7 @@
>  extern stream_info_t stream_info_mf;
>  extern stream_info_t stream_info_file;
>  #ifdef USE_DVDREAD
> +extern stream_info_t stream_info_ifo;
>  extern stream_info_t stream_info_dvd;
>  #endif
>
> @@ -132,6 +133,7 @@
>  #endif
>    &stream_info_cue,
>  #ifdef USE_DVDREAD
> +  &stream_info_ifo,
>    &stream_info_dvd,
>  #endif
>  #ifdef USE_DVDNAV
> @@ -189,6 +191,10 @@
>      }
>      streaming_ctrl_free(s->streaming_ctrl);
>  #endif
> +#ifdef USE_DVDREAD
> +    if (*ret == STREAM_REDIRECTED && s->type == STREAMTYPE_DVD)
> +      *redirected_url = strdup("dvd://");
> +#endif
>
> BTW, this is totally unacceptable. I didn't spend my
> time adapting all stream readers to the new api to see
> my effort vanified with the reintroduction of special
> cases handling.

Is attached version better?

> BTW2, using the "file"  prefix doesn't permit to identify
> the stream type unequivocally; better use ifo:// instead

Using "file" and "" allows user to specify "mplayer /patch/to/file.ifo"
and enjoy watching dvd.
Stream type will be STREAMTYPE_DVD.
Will proper console message be enough?

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: stream_dvd_ifo.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20071201/c371f4bd/attachment.txt>