[MPlayer-dev-eng] [PATCH] silence "Please run ./configure again" if config.h wasn't changed

[Diego Biurrun]

On Wed, Aug 29, 2007 at 09:48:31AM +0000, Carl Eugen Hoyos wrote:
> 
> Diego Biurrun <diego <at> biurrun.de> writes:
> 
> > > Attached patch should silence the "Please run ./configure again warning"
> > > from make after configure didn't change config.h.
> > > 
> > > --- Makefile	(Revision 24250)
> > > +++ Makefile	(Arbeitskopie)
> > >  <at>  <at>  -313,7 +313,7  <at>  <at> 
> > >  
> > >  # ./configure must be rerun if it changed
> > > -config.h: configure
> > > +config.mak: configure
> > >  	 <at> echo "############################################################"
> > >  	 <at> echo "####### Please run ./configure again - it's changed! #######"
> > >  	 <at> echo "############################################################"
> > 
> > What's the point of this?  If configure changed, config.h might have
> > changed as well.  AFAICT this is correct.  Do you wish to make
> > config.mak depend on configure as well?  This I could understand.
> 
> Sorry, I thought you were the one committing r24241.

I was.

> (All the following expects make dep was used - Neither my patch nor r24241 make
> much sence if not, IMO.)

Correct.  I always use 'make depend'.  Doesn't everybody?  I have a
hunch not everybody does..

> Before, whenever configure was updated via svn, make shouted "run configure
> again" and afterwards, the whole mplayer tree was needlessly rebuild.
> Now after configure was updated via svn and I rerun it because of makes "run
> configure again", only parts are rebuild: I think this patch was ingenious!
> But unfortunately, after svn was updated, (make shouted,) configure run again
> (did not change config.h, fortunately), make still shouts "run configure again"
> because config.h is older than configure.
> IMO, my patch fixes this: make shouts after configure was changed (it's newer
> than config.mak), after configure was run it doesn't shout (no matter if
> config.h was changed or not).
> 
> Please comment (but do not revert r24241), Carl Eugen

Yes, you are right.  The dependency on config.h is taken care of by make
depend anyway.  Go ahead and apply your patch.

Diego