[MPlayer-dev-eng] [PATCH] silence "Please run ./configure again" if config.h wasn't changed

[Diego Biurrun]

On Wed, Aug 29, 2007 at 11:11:20AM +0200, Reimar Döffinger wrote:
> On Wed, Aug 29, 2007 at 11:00:22AM +0200, Diego Biurrun wrote:
> > On Tue, Aug 28, 2007 at 12:21:21AM +0200, Carl Eugen Hoyos wrote:
> > > 
> > > Attached patch should silence the "Please run ./configure again warning"
> > > from make after configure didn't change config.h.
> > > 
> > > --- Makefile	(Revision 24250)
> > > +++ Makefile	(Arbeitskopie)
> > > @@ -313,7 +313,7 @@
> > >  
> > >  # ./configure must be rerun if it changed
> > > -config.h: configure
> > > +config.mak: configure
> > >  	@echo "############################################################"
> > >  	@echo "####### Please run ./configure again - it's changed! #######"
> > >  	@echo "############################################################"
> > 
> > What's the point of this?  If configure changed, config.h might have
> > changed as well.  AFAICT this is correct.  Do you wish to make
> > config.mak depend on configure as well?  This I could understand.
> 
> No, the problem is that if configure changed, but config.h didn't, there
> is no way to get rid of this message except distclean (or deleting it).
> Probably configure should always touch config.h

No, if config.h gets touched, everything that depends on config.h gets
(needlessly) rebuilt.  That is, mostly everything gets rebuilt.

Diego