[MPlayer-dev-eng] [PATCH] tvi_bsdbt848.c cleanup: perror -> mp_msg

Vladimir Voroshilov voroshil at gmail.com
Sun Aug 26 19:01:04 CEST 2007


2007/8/26, Vladimir Voroshilov <voroshil at gmail.com>:
> 2007/8/26, Reimar Doeffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > Hello,
> > On Sun, Aug 26, 2007 at 06:54:26PM +0700, Vladimir Voroshilov wrote:
> > > 2007/8/26, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> > [...]
> > > > Well, I find that "%s: " incredibly stupid, but it is already done in
> > > > other places, so feel free to do it however you like.
> > > >
> > >
> > > Is this version better ?
> >
> > Looks good to me, though the errno number itself is a rather useless
> > information, you can expect strerror to have correct messages for all
> > valid values.
> > I think Bernd would have prefered it if you added a space after each ','
> > in the function calls, but I haven't checked if that matches the style
> > of the file.
> > IMO feel free to apply anytime.
>
> Ok. I'll apply with spaces and errno removed.

Done


-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719



More information about the MPlayer-dev-eng mailing list