[MPlayer-dev-eng] [PATCH] TV auto scan and channel list in file

[Vladimir Voroshilov]

Hi, Bernd

2007/8/26, Bernd Ernesti <mplayer-dev-eng at lists.veego.de>:
> On Sat, Aug 25, 2007 at 06:06:08PM +0700, Vladimir Voroshilov wrote:
> > 2007/8/25, Bernd Ernesti <mplayer-dev-eng at lists.veego.de>:
> > > BUT, it always scans the channels even when I don't use -tvscan (just
> > > mplayer tv://1).
> >
> > It should not start scanning even you pass -tvscan option.
> > Only "-tvscan autostart" starts scanning after MPlayer startup.
>
> I know, but for me a scan is always issued while using the tv mode.
> What I don't understand the tvh->tv_param->scan handling and why we need
> it in so many places.

1. scan member is set to 1 either with tv_start_scan or with tvscan option.
2. is scan member is set each "period" seconds tv_scan routine is
called from ds_fill_packet. Routine checks signal and sets next call
timestamp.
3. It also sets scan member to zzero if scanning is finished.
4. scan also filled by zero during switching to another channel,
changing frequency through slave command etc. We cant zero scan member
in tV_set_freq because it is also called during scanning process.

> Maybe you forget to add some tvh->tv_param->scan=0; protection lines.

scan member can be set to 1 only through tv_start_scan or through
options subsystem not at init stage code.

> One problem is in cfg-mplayer.h. See attached patch. This is needed so a
> .mplayer/config entry would work with the tvscan options (e.g. tvscan=autostart=0)

Thanks for patch, applied.

 > But this doesn't fix the default autostart mode for me.
>
> The tv_start_scan code path was not used because the "start scan" output didn't
> happen.

One possible case excluded.
I've got your situation only once - when i've updated tv_param_t in
tv.h and forget to do make distclean. Just to exclude another case:
did you "make distclean" after r24125?

> > > Btw, tvi_bsdbt848.c needs some cleanup because it wasn't using mp_msg
> > > before your patch. A lot of perror remains in it, which has to be fixed
> > > in another run.
> >
> > And a one big indentation patch ;)
>
> Yeah, more in the other thread, after my autostart problem is fixed.

Sure.

> > > > I want to see printed value for active and inactive channels.
> >
> > > - inactive
> > > tvi_bt848: get signal 0x4
> > > - active
> > > tvi_bt848: get signal 0x2
> >
> Yes, I'm sure. This maybe a difference how the signal value is set on
> linux and the real meaning of the registers.
>
> [...]
>
> *(int*)arg = status & 0x02 ? 100 : 0;
>
> works for me.

Let it be so.

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719