[MPlayer-dev-eng] [PATCH] tvi_bsdbt848.c cleanup: perror -> mp_msg

Bernd Ernesti mplayer-dev-eng at lists.veego.de
Sun Aug 26 10:29:57 CEST 2007


On Sun, Aug 26, 2007 at 10:13:42AM +0200, Reimar Döffinger wrote:
> Hello,
> On Sun, Aug 26, 2007 at 01:50:18AM +0700, Vladimir Voroshilov wrote:
> > Attached patch replaces all occurances of perror(...) to
> > mp_msg(MSGT_TV,MSGL_ERR,...).
> > 
> > BSD guys, please make compilation test.
> 
> That makes the message much less helpful, I think you should append
> strerror(errno);

That and changing the lines from
 mp_msg(MSGT_TV,MSGL_ERR,"tvi_bsdbt848:
to
 mp_msg(MSGT_TV, MSGL_ERR, "%s:
too.

I prefer to use more spaces because it makes code more readable.

I haven't test it yet, because i still need to find a way out of my
tvscan problem and looking for some more chip communication docs.

Bernd




More information about the MPlayer-dev-eng mailing list