[MPlayer-dev-eng] [PATCH] Latin National Sub-Sets with teletext

Vladimir Voroshilov voroshil at gmail.com
Sat Aug 25 21:42:45 CEST 2007


Hi, Otvos!
Thanks for testing.

2007/8/26, Ötvös Attila <oattila at chello.hu>:
> 2007. augusztus 25. 18.47 dátummal Vladimir Voroshilov ezt írta:
> > Hi, Otvos
> >
> > Please test attached patch.
> > This is simplified version of your patch.
> Hi Vladimir Voroshilov!
>
> I corrected:
> --- tvi_vbi.c
> +++ tvi_vbi.c
> @@ -295,8 +295,8 @@
>                  return latin_subchars[lang][p-0x23];
>              }else if (p==0x40){
>                  return latin_subchars[lang][2];
> -            }else if (p>=0x5c && p<=0x60){
> -                return latin_subchars[lang][p-0x5c+3];
> +            }else if (p>=0x5b && p<=0x60){
> +                return latin_subchars[lang][p-0x5b+3];
>              }else if (p>=0x7b && p<=0x7e){
>                  return latin_subchars[lang][p-0x7b+9];
>             }
>
> I think this patch work with latin charset.
> I test:
> Hungarian, German (PRO7), French (TV5), Italian (Rai Uno).
>

This means that tested patch works as it should.
I'll apply it soon.

> I think problem with charset:
>
> Old:
> lang=d[7] & 0x7;
> lang==3 -> charset=RUS_UNI in lang2id()
>
> New:
> lang=(d[7]>>1)&0x7;
> lang==3 -> charset=RUS_UNI in lang2id()
>
> Old Russian lang=3
> New Russian lang=1 (3>>1)!
>
> lang=1 French
> lang=3 Czech/Slovak but charset RUS_UNI?

Existing code for Russian is ugly hack.

> I that is way make lang + langsub:
> lang with lang2id
> langsub with Sub-Sets
>
> I sorry. I can't test Russian (PTP -> No tetelext).

Teletext exists only on 1TV for me.
I have proper solution for language selection (using X/28/0 packets),
i just didn't want to mix it with this patch.

-- 
Regards,
Vladimir Voroshilov     mailto:voroshil at gmail.com
JID: voroshil at gmail.com, voroshil at jabber.ru
ICQ: 95587719



More information about the MPlayer-dev-eng mailing list