[MPlayer-dev-eng] [PATCH] Fix crash when using win32 codecs on mac osx / intel

Ulion ulion2002 at gmail.com
Sat Aug 25 15:52:19 CEST 2007


Hello,

Indeed, after a review, I found the problem is still there just like
the test in http://www.dribin.org/dave/blog/archives/2006/12/05/missing_third_param/

I use the simple source supplied by blog to test with gcc flag
-mstackrealign to compile, when use optimization flag -O, everything
is ok, but if using optimizer above -O2 , all got the incorrect result
like the bog said, miss the third paramter.
Without -mstackrealign flag, all results are correct. loader/win32.o
normally use -O4 to compile, so it's still has danger to got an
unwanted result when using a binary codecs, just currently not
founded.
And my gcc version is just exactly same with the blog author used one
at the end of blog mentioned.

So, feel free to add a -fno-unit-at-a-time flag to prevent the problem
(it works as the blog said) until it be fixed in a future gcc version
on Darwin Intel.

-- 
Ulion



More information about the MPlayer-dev-eng mailing list