[MPlayer-dev-eng] Patch for Position indicator for MPEG over HTTP

Johannes Deisenhofer jo.deisenhofer at googlemail.com
Fri Aug 24 18:07:08 CEST 2007


>> sizeof(off_t) may be != sizeof(long), but this patch is good enough for me
> 
> That would mean it might break playback of anything bigger than 2 GB

Yeah, there was a atoll() in there, before my last change. Sorry, I have 
been sloppy. This was verified (before the last-minute fix) with files 
 >4GB, but on a 64bit machine. Will check in 32bit.

 > over http. I am also not sure what effect it will have on mov-playback.

I'll try it.

> And lastly, is Content-Length guaranteed to be the correct value?

RFC 2616, 14.13
"The Content-Length entity-header field indicates the size of the 
entity-body, in decimal number of OCTETs"

> This patch IMO has a huge potential for breaking things...
> 

I'll make a version that will adress your concerns.

Jo



More information about the MPlayer-dev-eng mailing list