[MPlayer-dev-eng] [PATCH] Fix crash when using win32 codecs on mac osx / intel

[Reimar Döffinger]

Hello,
On Fri, Aug 24, 2007 at 01:48:14AM +0200, Diego Biurrun wrote:
> On Thu, Aug 23, 2007 at 08:40:01AM +0800, Ulion wrote:
> > 2007/8/23, Diego Biurrun <diego at biurrun.de>:
> > > >
> > > > --- loader/Makefile   (revision 24105)
> > > > +++ loader/Makefile   (working copy)
> > > > @@ -11,8 +11,12 @@
> > > >  # QTX emulation is not supported in Darwin
> > > >  ifneq ($(TARGET_OS),Darwin)
> > > >  SRCS_COMMON += wrapper.S
> > > > +else
> > > > +ifeq ($(ARCH_X86),yes)
> > > > +win32.o: CFLAGS += -mstackrealign -fno-unit-at-a-time
> > > >  endif
> > > >  endif
> > > > +endif
> > >
> > > The patch is wrong, you are enabling this on Linux as well.  Rejected.
> > 
> > Please check it again, before modified code, is testing if target os
> > is not Darwin, then else, here must be target os darwin, and then make
> > sure it's darwin on x86. Why you said it enable it on Linux as well?
> > 
> > How about make it clear in this new attachment. Or should I check
> > other condition instead of 'target os'? Any advice?
> 
> No, sorry, you are right, I misread.  However, it is not necessary to
> check for ARCH_X86, the loader works only on x86 anyway.
> 
> Reimar, do you have any objections to this patch?  Otherwise I'm fine
> with a cleaned-up version that has the above issue resolved.

Well, the problem I have is that if -fno-unit-at-a-time is needed, it
should be needed on non-Darwin as well, unless it is a bug Apple
introduced - and the blog post makes it look very much like a bug.
So I'd stll like to know if someone got it to work without
-fno-unit-at-a-time with at least some compiler version.

Greetings,
Reimar Döffinger