[MPlayer-dev-eng] [PATCH] Correct format conversion in stream_vstream.c

[Reimar Döffinger]

Hello,
On Fri, Aug 24, 2007 at 01:20:46AM +0200, Carl Eugen Hoyos wrote:
> Attached patch should fix one warning concerning format conversion in
> stream_vstream.c. Is %"PRIu64" correct for uint64_t (stream->end_pos)?

Yes, but
1) stream->end_pos is off_t, which is not necessarily uint64_t
2) The original was %d, so it should be PRId64 at least for now.

About the off_t problem, either cast stream->end_pos to int/unsigned or
do the PRId64 change and cast it to uint64_t.
A patch that replaces off_t by something like libav* offset_t that is
always 64 bit IMO would be welcome, too.

Greetings,
Reimar Döffinger