[MPlayer-dev-eng] Better handling of low FPS and still images

Uoti Urpala uoti.urpala at pp1.inet.fi
Fri Aug 24 04:34:03 CEST 2007


On Thu, 2007-08-23 at 21:36 -0400, Rich Felker wrote:
> > Uoti Urpala <uoti.urpala at pp1.inet.fi> wrote:
> > 
> > > [0001-Use-bitfield-instead-of-manual-bit-fiddling-in-input.patch

> I'm against ever using bitfields, for technical reasons. It's
> impossible to copy, compare, or manipulate multiple bits at once
> because each one acts like a separate variable.

The code does not manipulate multiple bits at once. It's purely the
syntax difference between

structure.field = 0;

and

structure.flags &= ~FIELDNAME_MACRO;

and corresponding differences in other similar constructs. Even if there
were no bitfields it would still be better in this case to use separate
variables rather than a flags field.

>  As far as I'm
> concerned, putting bitfields in the C language was a very stupid
> mistake in the first place.

I'm sure a lot of people are interested in your views vs those of the
standards committee on this matter.




More information about the MPlayer-dev-eng mailing list