[MPlayer-dev-eng] [PATCH] Fix warning/Remove uninitialized variable in stream_dvdnav.c
Nico Sabbi
nsabbi at email.it
Thu Aug 23 23:57:37 CEST 2007
Carl Eugen Hoyos wrote:
>Hi!
>
>stream_dvdnav.c: In function 'open_s':
>stream_dvdnav.c:401: warning: 'status' is used uninitialized in this
>function
>
>Variable status in open_s() in stream_dvdnav.c was never initialized
>since it was added in r18715. Patch to remove the variable is attached.
>
>I'll apply next week if nobody complains, Carl Eugen
>
>
>------------------------------------------------------------------------
>
>Index: stream/stream_dvdnav.c
>===================================================================
>--- stream/stream_dvdnav.c (Revision 24128)
>+++ stream/stream_dvdnav.c (Arbeitskopie)
>@@ -355,7 +355,6 @@
> struct stream_priv_s* p = (struct stream_priv_s*)opts;
> char *filename;
> dvdnav_priv_t *priv;
>- dvdnav_status_t status;
>
> if(p->device) filename = p->device;
> else if(dvd_device) filename= dvd_device;
>@@ -398,7 +397,7 @@
>
> update_title_len(stream);
> if(!stream->pos)
>- mp_msg(MSGT_OPEN,MSGL_ERR, "INIT ERROR: %d, couldn't get init pos %s\r\n", status, dvdnav_err_to_string(priv->dvdnav));
>+ mp_msg(MSGT_OPEN,MSGL_ERR, "INIT ERROR: couldn't get init pos %s\r\n", dvdnav_err_to_string(priv->dvdnav));
>
> mp_msg(MSGT_OPEN,MSGL_INFO, "Remember to disable MPlayer's cache when playing dvdnav:// streams (adding -nocache to your command line)\r\n");
>
>
>
trivial patch, you don't need a blessing
More information about the MPlayer-dev-eng
mailing list