[MPlayer-dev-eng] [PATCH] Fix crash when using win32 codecs on mac osx / intel

[Ulion]

2007/8/23, Diego Biurrun <diego at biurrun.de>:
> >
> > --- loader/Makefile   (revision 24105)
> > +++ loader/Makefile   (working copy)
> > @@ -11,8 +11,12 @@
> >  # QTX emulation is not supported in Darwin
> >  ifneq ($(TARGET_OS),Darwin)
> >  SRCS_COMMON += wrapper.S
> > +else
> > +ifeq ($(ARCH_X86),yes)
> > +win32.o: CFLAGS += -mstackrealign -fno-unit-at-a-time
> >  endif
> >  endif
> > +endif
>
> The patch is wrong, you are enabling this on Linux as well.  Rejected.
>
> Diego
>

Please check it again, before modified code, is testing if target os
is not Darwin, then else, here must be target os darwin, and then make
sure it's darwin on x86. Why you said it enable it on Linux as well?

How about make it clear in this new attachment. Or should I check
other condition instead of 'target os'? Any advice?

-- 
Ulion
-------------- next part --------------
Index: loader/Makefile
===================================================================
--- loader/Makefile	(revision 24105)
+++ loader/Makefile	(working copy)
@@ -33,6 +33,12 @@
 
 CFLAGS+=-fno-omit-frame-pointer -mno-omit-leaf-frame-pointer
 
+ifeq ($(TARGET_OS),Darwin)
+ifeq ($(ARCH_X86),yes)
+win32.o: CFLAGS += -mstackrealign -fno-unit-at-a-time
+endif
+endif
+
 dshow/test: dshow/test.c $(LIBNAME)
 	$(CC) $(CFLAGS) -o $@ $^ -lstdc++