[MPlayer-dev-eng] [PATCH] OS/2 - stream

[Diego Biurrun]

On Mon, Aug 20, 2007 at 10:33:06PM +0900, KO Myung-Hun wrote:
> 
> Diego Biurrun wrote:
> > On Sat, Aug 18, 2007 at 05:55:15PM +0900, KO Myung-Hun wrote:
> >   
> >> This is a patch of 'stream' for OS/2.
> >>
> >> --- stream/udp.c    (revision 24089)
> >> +++ stream/udp.c    (working copy)
> >> @@ -43,6 +43,10 @@
> >>  
> >> +#ifndef HAVE_SOCKLEN_T
> >> +typedef int socklen_t;
> >> +#endif
> >>  
> >> --- stream/tcp.c    (revision 24089)
> >> +++ stream/tcp.c    (working copy)
> >> @@ -34,6 +34,10 @@
> >>  
> >> +#ifndef HAVE_SOCKLEN_T
> >> +typedef int socklen_t;
> >> +#endif
> >>  
> >> --- stream/librtsp/rtsp_rtp.c   (revision 24089)
> >> +++ stream/librtsp/rtsp_rtp.c   (working copy)
> >> @@ -45,6 +45,10 @@
> >>  
> >> +#ifndef HAVE_SOCKLEN_T
> >> +typedef int socklen_t;
> >> +#endif
> >
> > I'm sure there is a way to have this in just one common place.
> >   
> I also thought about that at first. First candidate was 'config.h'. But 
> 'libavformat/os_support.h' also had it because of the same reason as 
> stream part. So gcc complained about 'redefinition'. Of course, I can 
> modify libavformat/os_support.h, but it is a part of FFmpeg. And these 
> require another work, right ? So I decided to do that way.
> 
> Anyway, those files seem not to have common user header files. Would you 
> mind advicing to me ?

I don't see such a warning as a big problem ..

Diego