[MPlayer-dev-eng] mplayer/trunk/gui/interface.c - fix gconvert_uri_to_filename

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Mon Aug 20 17:41:35 CEST 2007


Hello,
On Mon, Aug 20, 2007 at 05:30:16PM +0300, Ivan Kalvachev wrote:
> 2007/8/20, A C Hurst <A.Hurst at sheffield.ac.uk>:
> > Attaching a revised patch to fix gconvert_uri_to_filename(),
> >
> > I re-iterate, iive is already working on this, and I post for comparison only.
> >
> > I'm sorry if I'm spamming the list: I haven't debugged any C in a long time and am probably
> > over-enthusiastic.
> 
> Fix committed.
> 
> We already have function that un-escapes %XX.
> Also iconv conversion doesn't seem to be necessary and my Cyrillic
> setup seems to work just fine without it.
> 
> gconvert is the most horrible function I've seen (in public project).
> It have never worked correctly.

Most gui code is/was like this. There _is_ a reason why we don't develop
it further besides lack of interest.

Greetings,
Reimar Döffinger



More information about the MPlayer-dev-eng mailing list