[MPlayer-dev-eng] [PATCH] dvdread/bswap.h

[Reimar Döffinger]

Hello,
On Sun, Aug 19, 2007 at 01:43:40PM +0200, Nico Sabbi wrote:
> Reimar Döffinger wrote:
> > On Sun, Aug 19, 2007 at 12:43:11AM +0200, Reimar D?ffinger wrote:
> > 
> >>On Sun, Aug 19, 2007 at 07:40:45AM +1000, Daniel Jacob Werner wrote:
> >>
> >>>Compilation of dvdread/ifo_read.c fails on Solaris 10 Nevada / AMD64
> >>>with gcc version 3.4.3 targeting Nocona.
> >>
> >>Here is a patch that simply gets rid of the whole messy file and use a
> >>16-lines replacement.
> >>What about the diff? IMO there's no point in adding a proper diff
> >>between this and the distribution file since it's a complete
> >>replacement (the current diff should of course be removed).
> > 
> > Applied in that way.
> 
> this complicates a bit matters for me: the new dvdread and mplayer's
> will differ in at least the usage of libavutil/bswap.h.

It can be changed back as soon as we have a new dvdread that we can fix
ourselves to use something sane (IMO just plain C versions that are not
as brain-dead as the current dvdread ones should be good enough - the
places where these are used seem very far from speed critical).

Greetings,
Reimar Döffinger