[MPlayer-dev-eng] [PATCH] double click support on Mac OSX

[Reimar Döffinger]

Hello,
On Sat, Aug 18, 2007 at 11:56:05AM +0800, Ulion wrote:
> I found vo driver on mac osx does not send all necessary mouse events,
> that caused lack of support for double click events, here's the patch.
> 
> 1. send mouse down events correctly so mplayer can detect double click
> correctly.
> 2. send mouse up events, to release corresponding mouse down events.
> 3. detect up to 10 buttons up and down events.

Ideally separate things should be done in separate patches (esp. the
purely cosmetic renaming of the MouseEvent function into
MouseDownEvent - couldn't you just add a parameter that decides between
up and down?).
But more importantly, you should use
MOUSE_BTN0 + ...
instead of
MOUSE_BASE + ...

Greetings,
Reimar Döffinger