[MPlayer-dev-eng] [PATCH] fix stubs to teletext

[Reimar Döffinger]

Hello,
On Tue, Aug 14, 2007 at 06:06:23PM +0200, ?tv?s Attila wrote:
[...]

Did you forget the
> +    if (priv->eoc-priv->soc < (int)(16*priv->bpb/ONE_FIXP)) {
or remove it on purpose?

> +    priv->soc=FFMAX((int)(9.2e-6*priv->ptsp->sampling_rate)-priv->ptsp->offset,0);
> +    priv->eoc=FFMIN((int)(12.9e-6*priv->ptsp->sampling_rate)-priv->ptsp->offset,
> +                    priv->ptsp->samples_per_line-(int)(43*8*priv->bpb/ONE_FIXP));

Did you try without the casts? I think they only complicate the code
while making no difference at all. I'd also vertically align the code
and add a few spaces (making out the difference between "->", "-" and
"e-" is a bit difficult without) like this:

>     priv->soc=FFMAX( 9.2e-6 * priv->ptsp->sampling_rate - priv->ptsp->offset, 0);
>     priv->eoc=FFMIN(12.9e-6 * priv->ptsp->sampling_rate - priv->ptsp->offset,
>                     priv->ptsp->samples_per_line - 43 * 8 * priv->bpb / ONE_FIXP);

I'd also like it if Vladimir could review and apply it, since he
actually knows and uses that code, but if not I'll do it somewhen.

Greetings,
Reimar Döffinger