[MPlayer-dev-eng] [PATCH] Apple Remote support

? ? ulion2002 at msn.com
Sat Aug 11 19:01:45 CEST 2007



>From: Diego Biurrun <diego at biurrun.de>
>
>Look at vidix/vidixlib.c.  Yes, I know we're not (yet) very consistent,
>but you have to start somewhere...
ok, I got it.

>
> > >Mixed tabs and spaces.  I prefer spaces.
> > since original author of this file ar.c (first post is here:
> > 
>http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-July/053076.html )
> > almost all use tabs in the source except this little part, I will fix 
>this
> > all into tabs, I think it's also acceptable.
>
>I would really prefer spaces, most of the others here prefer spaces as
>well.  It's the FFmpeg coding style.
ok, all tabs in ar.c converted to spaces.

>
> > >cosmetics
> > it's for align to the right equal, all spaces, should I remove it?
>
>That should be done in a separate patch.
ok, fixed, it.

here's the updated patch, beside all formating fix and license header added, 
it includes other fixes:
1. compile warnings removed
2. change keycode mapping method to prevent from using un-inited keycode 
mapping value
3. check whether current process in front to close or re-open the HID device 
interface, this will fix the problem that system and mplayer react at same 
time with Apple Remote's motion when mplayer not in front or after mplayer 
be reseted back to front.

Ulion

-------------- next part --------------
A non-text attachment was scrubbed...
Name: apple_remote_all.patch
Type: application/octet-stream
Size: 26372 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070811/a0c0dcae/attachment.obj>


More information about the MPlayer-dev-eng mailing list