[MPlayer-dev-eng] [PATCH] Apple Remote support

[Diego Biurrun]

On Fri, Aug 10, 2007 at 08:22:39PM -0400, ? ? wrote:
> 
> > > --- input/ar.c	(revision 0)
> > > +++ input/ar.c	(revision 0)
> > > @@ -0,0 +1,283 @@
> > > +
> > > +#include <math.h>
> > > +#include <sysexits.h>
> > > +#include <IOKit/IOCFPlugIn.h>
> > > +#include <IOKit/hid/IOHIDLib.h>
> >
> >New files should have a proper license header.
> all other files in the same directory 'input' has no license header, so I 
> don't known what kind of license header should be use, can you give me a 
> guide?

Look at vidix/vidixlib.c.  Yes, I know we're not (yet) very consistent,
but you have to start somewhere...

> >Mixed tabs and spaces.  I prefer spaces.
> since original author of this file ar.c (first post is here: 
> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-July/053076.html ) 
> almost all use tabs in the source except this little part, I will fix this 
> all into tabs, I think it's also acceptable.

I would really prefer spaces, most of the others here prefer spaces as
well.  It's the FFmpeg coding style.

> > > --- input/Makefile	(revision 24045)
> > > +++ input/Makefile	(working copy)
> > > @@ -2,8 +2,9 @@
> > >
> > > -SRCS_MPLAYER              = input.c
> > > -SRCS_MPLAYER-$(JOYSTICK) += joystick.c
> > > -SRCS_MPLAYER-$(LIRC)     += lirc.c
> > > +SRCS_MPLAYER                  = input.c
> > > +SRCS_MPLAYER-$(JOYSTICK)     += joystick.c
> > > +SRCS_MPLAYER-$(LIRC)         += lirc.c
> > > +SRCS_MPLAYER-$(APPLE_REMOTE) += ar.c
> >
> >cosmetics
> it's for align to the right equal, all spaces, should I remove it?

That should be done in a separate patch.

Diego