[MPlayer-dev-eng] [PATCH] dvdnav part 2 - still frames

Ötvös Attila oattila at chello.hu
Tue Aug 7 23:46:27 CEST 2007


2007. augusztus 6. 10.38 dátummal Diego Biurrun ezt írta:
Hi Diego Biurrun!

I correction this patch.

> > + * \param stream: - stream pointer
> > + * \return 1 if success
>
> on success
>
> Shouldn't successful function calls return 0?
>

I change: 0 = success

> > +                    mp_msg(MSGT_CPLAYER,MSGL_ERR,
> > +                        "Can't decode still frame.\n"
> > +                        "Please try to -vc ffmpeg12 options.\n");
>
> This is ungrammatical, where is the verb that needs to follow "to".
> What are you trying to say?
>

If MPlayer can't decode still frames with libmpeg2 then try MPlayer with 
ffmpeg.

Thank you.

Best regard.
Attila

PS: I am sorry to say that my English knowledge isn't good.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dvdnav-2.patch
Type: text/x-diff
Size: 23828 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20070807/777c950d/attachment.patch>


More information about the MPlayer-dev-eng mailing list