[MPlayer-dev-eng] [PATCH] modify_reg.c

[Reimar Döffinger]

Hello,
On Mon, Aug 06, 2007 at 11:25:57AM +0200, Carl Eugen Hoyos wrote:
> Reimar Döffinger wrote:
[...]
> >> +  strncpy(key, tmpkey + 1, strlen(tmpkey)-1);
> >> +  key[strlen(tmpkey)-1] = 0;
> > 
> > Too bad av_strlcpy is not available... But maybe it's worth
> > copy-and-pasting it?
> 
> Is this really necessary?

Certainly not, it might just look a bit nicer. But since it's now down
from 4 to 2 places I don't think it is worth bothering with.
I'd make the indentation consistently always 4 or always 2 space though.
Otherwise I think it looks good enough for TOOLS/ at least (didn't do a really
proper review).

Greetings,
Reimar Döffinger